New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new DeploymentBranchPolicies endpoints #2621
Add new DeploymentBranchPolicies endpoints #2621
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Ismael-Moreno !
Please make sure to run gofmt
on your source files.
Also, please make sure to not use force-push for your upcoming commit(s), since we always use squash-and-merge in this repo. See CONTRIBUTING.md for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Ismael-Moreno !
One minor nit, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Also, please make sure all unit tests pass locally before pushing the next commit. |
This last one pass the three checks shown in the Contributing guide: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Ismael-Moreno !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov Report
@@ Coverage Diff @@
## master #2621 +/- ##
==========================================
+ Coverage 98.02% 98.03% +0.01%
==========================================
Files 129 130 +1
Lines 11084 11144 +60
==========================================
+ Hits 10865 10925 +60
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @Parker77 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, @Ismael-Moreno - but as I was about to merge, I noticed that DeploymentBranchPolicies
is singular Deployment
whereas the new filenames are ..._deployments_branch_...
.
Could you please rename the new files to use a singular ..._deployment_...
please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Ismael-Moreno !
Merging.
This PR adds all the endpoints from deployment-branch-policies: https://docs.github.com/en/rest/deployments/branch-policies?apiVersion=2022-11-28#about-deployment-branch-policies
Fixes: #2610.