Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new DeploymentBranchPolicies endpoints #2621

Merged
merged 7 commits into from Jan 11, 2023
Merged

Add new DeploymentBranchPolicies endpoints #2621

merged 7 commits into from Jan 11, 2023

Conversation

Ismael-Moreno
Copy link
Contributor

@Ismael-Moreno Ismael-Moreno commented Jan 9, 2023

@google-cla
Copy link

google-cla bot commented Jan 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title new api deployment branch policy endpoint added Add new DeploymentBranchPolicies endpoints Jan 10, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Ismael-Moreno !
Please make sure to run gofmt on your source files.
Also, please make sure to not use force-push for your upcoming commit(s), since we always use squash-and-merge in this repo. See CONTRIBUTING.md for more info.

github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies_test.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Ismael-Moreno !
One minor nit, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/repos_deployments_branch_policies.go Outdated Show resolved Hide resolved
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 10, 2023

Also, please make sure all unit tests pass locally before pushing the next commit.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 10, 2023
@Ismael-Moreno
Copy link
Contributor Author

This last one pass the three checks shown in the Contributing guide:
go generate github.com/google/go-github/...
go test github.com/google/go-github/...
go vet github.com/google/go-github/...
Please tell me if there is any other tests I'm missing, thank you for your patience.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Ismael-Moreno !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #2621 (5f0b24e) into master (838d223) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
+ Coverage   98.02%   98.03%   +0.01%     
==========================================
  Files         129      130       +1     
  Lines       11084    11144      +60     
==========================================
+ Hits        10865    10925      +60     
  Misses        150      150              
  Partials       69       69              
Impacted Files Coverage Δ
github/repos_deployment_branch_policies.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 10, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 10, 2023

Thank you, @Parker77 !
Merging.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @Ismael-Moreno - but as I was about to merge, I noticed that DeploymentBranchPolicies is singular Deployment whereas the new filenames are ..._deployments_branch_... .

Could you please rename the new files to use a singular ..._deployment_... please?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Ismael-Moreno !
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment Branch Policies is not implemented
3 participants