Add RequireLastPushApproval field to UpdateBranchProtection #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
gmlewis
requested changes
Jan 16, 2023
There was a problem hiding this comment.
Thank you, @liaodaniel!
This field is optional, so we need to treat it a bit differently.
Codecov Report
@@ Coverage Diff @@
## master #2629 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 130 130
Lines 11144 11144
=======================================
Hits 10925 10925
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
gmlewis
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2628
Signed-off-by: Daniel Liao 10663736+liaodaniel@users.noreply.github.com