Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NewTokenClient #2637

Merged
merged 6 commits into from Jan 25, 2023
Merged

Add NewTokenClient #2637

merged 6 commits into from Jan 25, 2023
+20 −0

Conversation

icholy
Copy link
Contributor

@icholy icholy commented Jan 20, 2023

Fixes #2636

gmlewis
gmlewis requested changes Jan 20, 2023
View reviewed changes
github/github.go Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited

Codecov Report

Merging #2637 (3548305) into master (2561c07) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2637   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         130      130           
  Lines       11242    11244    +2     
=======================================
+ Hits        11023    11025    +2     
  Misses        150      150           
  Partials       69       69
Impacted Files Coverage Δ
github/github.go 97.46% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@icholy
Copy link
Contributor Author

icholy commented Jan 20, 2023

I removed the context parameter since I think most users won't be needing it. Let me know if you disagree.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2023

I removed the context parameter since I think most users won't be needing it. Let me know if you disagree.

Yeah, one thing I learned at Google is that people sometimes do wild and wacky things with the context.
Let's please put it back in.

gmlewis
gmlewis approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @icholy !
LGTM.

Awaiting second LGTM+Approval from any other contributor to the repo.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 20, 2023
valbeat
valbeat approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@icholy
Copy link
Contributor Author

icholy commented Jan 25, 2023

Should I squash?

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 25, 2023

Should I squash?

No need to squash, as we always "Squash and Merge" all PRs in this repo. Thanks, though.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 25, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 25, 2023

Do you want to update an example before merging, @icholy ?

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 25, 2023

LGTM!

Thank you, @valbeat !

@icholy
Copy link
Contributor Author

icholy commented Jan 25, 2023

I'll do a separate PR later.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 25, 2023

I'll do a separate PR later.

Sounds great. Merging.

@gmlewis gmlewis merged commit 63c1dee into google:master Jan 25, 2023
@gmlewis gmlewis mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NewTokenClient constructor
3 participants
@icholy @gmlewis @valbeat