Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to update codescanning alert #2639

Conversation

ganeshkumarsv
Copy link
Contributor

@ganeshkumarsv ganeshkumarsv commented Jan 24, 2023

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #2639 (9aff982) into master (36c47d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9aff982 differs from pull request most recent head bc97c7f. Consider uploading reports for the commit bc97c7f to get more accurate results

@@           Coverage Diff           @@
##           master    #2639   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         130      130           
  Lines       11242    11257   +15     
=======================================
+ Hits        11023    11038   +15     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <100.00%> (ø)
github/github.go 97.46% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ganeshkumarsv ganeshkumarsv marked this pull request as draft January 24, 2023 20:54
@ganeshkumarsv ganeshkumarsv changed the title Feature add method to update codescanning alert Add method to update codescanning alert Jan 24, 2023
@ganeshkumarsv ganeshkumarsv marked this pull request as ready for review January 24, 2023 23:04
@ganeshkumarsv ganeshkumarsv force-pushed the feature__add_method_to_update_codescanning_alert branch from be4a2a0 to 308750d Compare January 24, 2023 23:33
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !

github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
ganeshkumarsv and others added 3 commits January 25, 2023 10:17
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please run gofmt on the newly-changed files and also make sure to run "go generate ./..." and push the changed files to this PR to get all the tests to pass?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and of course, please run "go test ./..." to catch the error in the test file.

@ganeshkumarsv
Copy link
Contributor Author

Thanks for the commit suggestion @gmlewis I fixed the test cases and generators.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @ganeshkumarsv - it looks like I made a couple mistakes in my suggestions.
Just a few minor tweaks, please.

github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 25, 2023
ganeshkumarsv and others added 3 commits January 25, 2023 12:22
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@ganeshkumarsv
Copy link
Contributor Author

@gmlewis we got 2 approvals on the PR. can you please merge the PR and create a new release?

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 26, 2023

@gmlewis we got 2 approvals on the PR. can you please merge the PR and create a new release?

Yes, but as for the new release, we already have breaking API changes and I would like to get #2646 approved and committed too before the major version change, so if you feel like reviewing that one, @ganeshkumarsv , that would speed the process along. Thanks.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 26, 2023

Thank you, @AbbanMustafa !
Merging.

@gmlewis gmlewis merged commit ef40760 into google:master Jan 26, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 26, 2023
@ganeshkumarsv
Copy link
Contributor Author

Thanks @gmlewis. I approved the PR

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 26, 2023

@ganeshkumarsv - this is now available in the v50.0.0 release: https://github.com/google/go-github/releases/tag/v50.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants