-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change total_minutes_used and included_minutes from int to float64 #2643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2643 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 130 130
Lines 11242 11242
=======================================
Hits 11023 11023
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @loispostula !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @valbeat ! |
@gmlewis np, any info regarding the next release date? |
The last release was 2 weeks ago, and we have a potentially broad-reaching breaking API change coming up shortly: #2645 Are you OK with that, @loispostula ? |
I'll continue using my fork while waiting ;) |
Fixes #2642
GitHub Actions returns total_minutes_used and included_minutes as floating point value.
The Implementation should accept this floating point value as float64.
Example