Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NewTokenClient in tests and examples #2644

Merged
merged 2 commits into from Jan 26, 2023
Merged

Conversation

icholy
Copy link
Contributor

@icholy icholy commented Jan 25, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #2644 (78aab68) into master (36c47d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2644   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         130      130           
  Lines       11242    11244    +2     
=======================================
+ Hits        11023    11025    +2     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/github.go 97.46% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @icholy !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 25, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 26, 2023

@Parker77 - do you have time for another?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 26, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 26, 2023

Thank you, @Parker77!
Merging.

@gmlewis gmlewis merged commit aa2c143 into google:master Jan 26, 2023
@Omobarew0
Copy link

Nice work more grace to your elbow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants