Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for actions variables #2652

Merged
merged 7 commits into from Feb 1, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 31, 2023

https://docs.github.com/en/rest/actions/variables

Fixes #2624

  • Added actions_variables.go
  • Added actions_variables_test.go

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@google-cla
Copy link

google-cla bot commented Jan 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title new(github): added support for actions variables. Add support for actions variables Jan 31, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FedeDP!
It looks great and with a few minor tweaks we should be ready for a second LGTM+Approval before merging.

github/actions_variables.go Outdated Show resolved Hide resolved
github/actions_variables.go Outdated Show resolved Hide resolved
github/actions_variables_test.go Outdated Show resolved Hide resolved
github/actions_variables.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #2652 (ac3a7b4) into master (8eac70f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
+ Coverage   98.08%   98.10%   +0.02%     
==========================================
  Files         130      131       +1     
  Lines       11304    11442     +138     
==========================================
+ Hits        11087    11225     +138     
  Misses        148      148              
  Partials       69       69              
Impacted Files Coverage Δ
github/actions_variables.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

FedeDP and others added 5 commits January 31, 2023 13:53
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
… and `ActionVariables`.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 31, 2023

Should've fixed everything ;) Thank you!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FedeDP !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 1, 2023

I merged master into this branch.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 1, 2023

LGTM!

Thank you, @valbeat !
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuration variables in workflows
3 participants