Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing unit tests for Go 1.20 #2656

Merged
merged 1 commit into from Feb 2, 2023

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 2, 2023

Fixes: #2654.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #2656 (a370400) into master (72dd8ad) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   98.10%   98.05%   -0.06%     
==========================================
  Files         131      131              
  Lines       11442    11442              
==========================================
- Hits        11225    11219       -6     
- Misses        148      152       +4     
- Partials       69       71       +2     
Impacted Files Coverage Δ
github/actions_artifacts.go 95.71% <0.00%> (-4.29%) ⬇️
github/repos_contents.go 87.58% <0.00%> (-1.97%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 2, 2023

Awaiting LGTM+Approval from any other contributor to this repo.

You can ignore the codecov/project drop in coverage. It turns out that with Go 1.20 we will no longer be able to cover these two lines, as it prevents us from creating a malformed URL in the Location header field.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 2, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit ef6c7a6 into google:master Feb 2, 2023
@gmlewis gmlewis deleted the i2654-bad-unit-tests branch February 2, 2023 11:57
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.20 causes two unit test failures relating to bad URLs
2 participants