Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account field to MarketplacePurchase struct #2659

Merged
merged 2 commits into from Feb 6, 2023

Conversation

lyspj
Copy link
Contributor

@lyspj lyspj commented Feb 3, 2023

Fixes #2658

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lyspj .
The documentation example here: https://docs.github.com/en/rest/apps/marketplace?apiVersion=2022-11-28#list-subscriptions-for-the-authenticated-user-stubbed

Lists more fields:

    "account": {
      "login": "github",
      "id": 4,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjE=",
      "url": "https://api.github.com/orgs/github",
      "email": null,
      "organization_billing_email": "billing@github.com",
      "type": "Organization"
    },

Could you please add them as well while we are here?

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #2659 (57f5802) into master (2094f99) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2659   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11442    11442           
=======================================
  Hits        11219    11219           
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/apps_marketplace.go 87.14% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lyspj
Copy link
Contributor Author

lyspj commented Feb 3, 2023

Thanks, @lyspj . The documentation example here: https://docs.github.com/en/rest/apps/marketplace?apiVersion=2022-11-28#list-subscriptions-for-the-authenticated-user-stubbed

Lists more fields:
...
Could you please add them as well while we are here?

Sure! I've added URL NodeID Email, which I think covers all the remaining fields.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 3, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lyspj !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 6, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 6, 2023
@gmlewis gmlewis merged commit 0af462f into google:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Account field to MarketplacePurchase struct
3 participants