Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Permission, OldPermission to AuditEntry type #2670

Merged
merged 3 commits into from Feb 22, 2023
Merged

Add Permission, OldPermission to AuditEntry type #2670

merged 3 commits into from Feb 22, 2023

Conversation

Archetypically
Copy link
Contributor

Fixes #2669

Changes

  • Add marshalling of the old_permission and permission fields in the response of GET /orgs/:org/audit-log to the AuditEntry type as AuditEntry.OldPermission and AuditEntry.Permission.

@google-cla
Copy link

google-cla bot commented Feb 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Archetypically
Copy link
Contributor Author

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed CLA.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 22, 2023

Thank you, @Archetypically ! Please make sure to run gofmt on your modified files and push the results to this PR.
No need to force-push... we always squash-and-merge.
For more details, please see CONTRIBUTING.md.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #2670 (53df8d6) into master (b9cb801) will not change coverage.
The diff coverage is n/a.

❗ Current head 53df8d6 differs from pull request most recent head bcf61da. Consider uploading reports for the commit bcf61da to get more accurate results

@@           Coverage Diff           @@
##           master    #2670   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11442    11442           
=======================================
  Hits        11219    11219           
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/orgs_audit_log.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Archetypically !
LGTM.
Merging after tests pass.

@gmlewis gmlewis merged commit e7e7149 into google:master Feb 22, 2023
@Archetypically
Copy link
Contributor Author

Thanks @gmlewis!

@Archetypically Archetypically deleted the org-update-member-audit-entry-fields branch February 22, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuditEntry struct type does not serialize org.update_member action fields
2 participants