-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Permission, OldPermission to AuditEntry type #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Permission, OldPermission to AuditEntry type #2670
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed CLA. |
Thank you, @Archetypically ! Please make sure to run |
Codecov Report
@@ Coverage Diff @@
## master #2670 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 131 131
Lines 11442 11442
=======================================
Hits 11219 11219
Misses 152 152
Partials 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Archetypically !
LGTM.
Merging after tests pass.
Thanks @gmlewis! |
Fixes #2669
Changes
old_permission
andpermission
fields in the response ofGET /orgs/:org/audit-log
to theAuditEntry
type asAuditEntry.OldPermission
andAuditEntry.Permission
.