Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DicussionCommentEvent Webhook #2678

Merged
merged 2 commits into from Mar 6, 2023

Conversation

apurwaj2
Copy link
Contributor

@apurwaj2 apurwaj2 commented Feb 25, 2023

This commit has changes to enable support to receive DiscussionComment Webhook Event, to fix google#2497 Changes include:

  • Addition of event type for this type of event DiscussionCommentEvent
  • Changes for identification and mapping of DiscussionCommentEvent
  • Addition / Modification of relevant tests
  • Addition of files created by go generate

This commit has changes to enable support to receive DiscussionComment Webhook Event, to fix google#2497
Changes include:
* Addition of event type for this type of event DiscussionCommentEvent
* Changes for identification and mapping of DiscussionCommentEvent
* Addition / Modification of relevant tests
* Addition of files created by go generate
@gmlewis gmlewis changed the title Add DicussionCommentEvent Webhook google#2497 Add DicussionCommentEvent Webhook Feb 26, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 26, 2023

Please run your files through "gofmt" as described in CONTRIBUTING.md.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #2678 (23a1718) into master (099fae4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2678   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11442    11444    +2     
=======================================
+ Hits        11219    11221    +2     
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github/event_types.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @apurwaj2 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Note that I'm OOO until around March 6, so I may not be able to merge this before then if we don't get an approval shortly.

@apurwaj2
Copy link
Contributor Author

Thank you, @apurwaj2 ! LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Note that I'm OOO until around March 6, so I may not be able to merge this before then if we don't get an approval shortly.

Sure. Thanks, for approving.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 6, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit a2087c7 into google:master Mar 6, 2023
exageraldo pushed a commit to exageraldo/go-github that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants