Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTP Proxy from environment #2686

Merged
merged 1 commit into from Mar 8, 2023
Merged

Support HTTP Proxy from environment #2686

merged 1 commit into from Mar 8, 2023

Conversation

hangscer8
Copy link
Contributor

@hangscer8 hangscer8 commented Mar 3, 2023 •
edited by gmlewis

Add the support of http prxoy to NewClientWithEnvProxy.

Relates to: #2363.

@hangscer8 hangscer8 changed the title support http proxy Support Http Proxy Mar 3, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 6, 2023

@hangscer8 - I'm concerned that this change is going to affect current users of this repo who are not expecting this behavior to be the default.

Could we instead add a new NewClientWithEnvProxy or something like that?

@hangscer8 hangscer8 force-pushed the add_support_http_proxy branch 2 times, most recently from ad08795 to d56db10 Compare March 7, 2023 01:58
@hangscer8
Copy link
Contributor Author

@hangscer8 - I'm concerned that this change is going to affect current users of this repo who are not expecting this behavior to be the default.

Could we instead add a new NewClientWithEnvProxy or something like that?

OK, I will fix that. @gmlewis

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. and removed waiting for reply labels Mar 8, 2023
gmlewis
gmlewis approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hangscer8 !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewis gmlewis changed the title Support Http Proxy Support HTTP Proxy Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited

Codecov Report

Merging #2686 (e64235c) into master (862134b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2686   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11457    11459    +2     
=======================================
+ Hits        11234    11236    +2     
  Misses        152      152           
  Partials       71       71
Impacted Files Coverage Δ
github/github.go 97.94% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hangscer8
support http proxy
e64235c 
Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
valbeat
valbeat approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 8, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 8, 2023

LGTM!

Thank you, @valbeat !
Merging.

@gmlewis gmlewis changed the title Support HTTP Proxy Support HTTP Proxy from environment Mar 8, 2023
@gmlewis gmlewis merged commit 14bb610 into google:master Mar 8, 2023
exageraldo pushed a commit to exageraldo/go-github that referenced this pull request Mar 13, 2023
@exageraldo
Support HTTP Proxy from environment (google#2686)
8ce92ae
@tu-tquin tu-tquin mentioned this pull request May 3, 2023
Open
@gmlewis gmlewis mentioned this pull request Aug 24, 2023
Open
@smittnacht smittnacht mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hangscer8 @gmlewis @valbeat