Support HTTP Proxy from environment #2686
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hangscer8 - I'm concerned that this change is going to affect current users of this repo who are not expecting this behavior to be the default. Could we instead add a new |
nothingcompare2u
force-pushed
the
add_support_http_proxy
branch
2 times, most recently
from
ad08795 to
d56db10
Compare
OK, I will fix that. @gmlewis |
gmlewis
added
NeedsReview
gmlewis
approved these changes
Mar 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #2686 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 131 131
Lines 11457 11459 +2
=======================================
+ Hits 11234 11236 +2
Misses 152 152
Partials 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
nothingcompare2u
force-pushed
the
add_support_http_proxy
branch
from
d56db10 to
e64235c
Compare
gmlewis
approved these changes
Mar 8, 2023
Thank you, @valbeat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support of http prxoy to
NewClientWithEnvProxy.Relates to: #2363.