Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add head_sha for ListWorkflowRunsOptions #2703

Merged
merged 1 commit into from Mar 8, 2023

Conversation

alexellis
Copy link
Contributor

Description

Add head_sha for ListWorkflowRunsOptions (fixes: #2687)

Why is this needed?

GitHub added this option to the following API:

/repos/{owner}/{repo}/actions/runs

Only returns workflow runs that are associated with the specified head_sha.

See also:

https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#list-workflow-runs-for-a-repository

GitHub added this option to the following API:

/repos/{owner}/{repo}/actions/runs

Only returns workflow runs that are associated with the specified
head_sha.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis
Copy link
Contributor Author

@gmlewis I've signed the CLA, and read the contributing guide, ran the unit tests through.

Let me know if you need anything else.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #2703 (20d595e) into master (862134b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2703   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11457    11457           
=======================================
  Hits        11234    11234           
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexellis !
LGTM.
Merging.

@gmlewis gmlewis changed the title Add head_sha for ListWorkflowRunsOptions (fixes: #2687) Add head_sha for ListWorkflowRunsOptions Mar 8, 2023
@gmlewis gmlewis merged commit 73075b9 into google:master Mar 8, 2023
exageraldo pushed a commit to exageraldo/go-github that referenced this pull request Mar 13, 2023
@alexellis alexellis deleted the head_sha_ListWorkflowRunsOptions branch March 14, 2023 11:51
@alexellis
Copy link
Contributor Author

Thanks for accepting the contribution @gmlewis

I used to write interactions with GitHub's API manually before discovering this client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List workflow runs for a repository by SHA
2 participants