Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set authenticated user's email visibility via API #2711

Merged
merged 7 commits into from Mar 31, 2023
Merged

Set authenticated user's email visibility via API #2711

merged 7 commits into from Mar 31, 2023
+69 −0

Conversation

Sairaviteja27
Copy link
Contributor

@Sairaviteja27 Sairaviteja27 commented Mar 19, 2023 •
edited

Fixes: #2688

@codecov
Copy link

codecov bot commented Mar 19, 2023 •
edited

Codecov Report

Merging #2711 (ffa0382) into master (a934ccc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2711   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11459    11476   +17     
=======================================
+ Hits        11236    11253   +17     
  Misses        152      152           
  Partials       71       71
Impacted Files Coverage Δ
github/users_emails.go 94.23% <100.00%> (+2.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 20, 2023

@Sairaviteja27 - please remove the "Draft" status when you want a PR to be reviewed.

@Sairaviteja27 Sairaviteja27 marked this pull request as ready for review March 28, 2023 10:39
@Sairaviteja27
Copy link
Contributor Author

Hi @gmlewis , marked it for review, thanks.

gmlewis
gmlewis requested changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !

github/users_emails.go Outdated Show resolved Hide resolved
gmlewis
gmlewis approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !
LGTM.

Awaiting LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 29, 2023
valbeat
valbeat approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 31, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 31, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit a29e30c into google:master Mar 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set authenticated user's email visibility via API
3 participants
@Sairaviteja27 @gmlewis @valbeat