Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download capability for workflow run attempt logs #2716

Merged
merged 3 commits into from Mar 29, 2023

Conversation

btacyildiz
Copy link
Contributor

@btacyildiz btacyildiz commented Mar 23, 2023

Fixes: #2715

@google-cla
Copy link

google-cla bot commented Mar 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@btacyildiz btacyildiz changed the title Add download workflow run attempt capability Add download capability for workflow run attempt logs Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2716 (5bc7592) into master (a934ccc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5bc7592 differs from pull request most recent head 07eb2c4. Consider uploading reports for the commit 07eb2c4 to get more accurate results

@@           Coverage Diff           @@
##           master    #2716   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11459    11473   +14     
=======================================
+ Hits        11236    11250   +14     
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@btacyildiz btacyildiz force-pushed the add-download-workflow-attempt-logs branch from 5bc7592 to 9510753 Compare March 23, 2023 22:31
@btacyildiz btacyildiz marked this pull request as ready for review March 23, 2023 22:36
@btacyildiz btacyildiz force-pushed the add-download-workflow-attempt-logs branch from 9510753 to fec6f56 Compare March 23, 2023 22:38
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @btacyildiz !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 27, 2023
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 29, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 29, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 983285f into google:master Mar 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add download capability for workflow attempt logs
3 participants