Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListOptions to GetAdvancedSecurityActiveCommittersOrg #2720

Merged

Conversation

ganeshkumarsv
Copy link
Contributor

@ganeshkumarsv ganeshkumarsv commented Mar 28, 2023

Adding Pagination support for fetching active committers in an organization.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 28, 2023

It looks like you are making a change that affects only Enterprise GitHub, correct?
According to the current documentation URL: https://docs.github.com/en/rest/billing?apiVersion=2022-11-28#get-github-advanced-security-active-committers-for-an-organization
there is no pagination supported by the current endpoint.

Is it different for GitHub Enterprise?

If so, please provide two docs URLs as seen in other methods in this repo.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Mar 28, 2023
@gmlewis gmlewis changed the title add listoptions to GetAdvancedSecurityActiveCommittersOrg Add ListOptions to GetAdvancedSecurityActiveCommittersOrg Mar 28, 2023
@ganeshkumarsv
Copy link
Contributor Author

I think the API endpoint is supported only for enterprise cloud: https://docs.github.com/en/enterprise-cloud@latest/rest/billing?apiVersion=2022-11-28#get-github-advanced-security-active-committers-for-an-organization

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 28, 2023

Oh, I see... the original URL was wrong then. Thanks.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@ganeshkumarsv
Copy link
Contributor Author

@gmlewis can we merge the PR? we got 2 approvals now.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 28, 2023

Thank you, @AbbanMustafa !
Merging.

@gmlewis gmlewis merged commit 6bba7a4 into google:master Mar 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants