Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CanAdminsBypass to Environment #2721

Merged
merged 4 commits into from Mar 28, 2023
Merged

Add CanAdminsBypass to Environment #2721

merged 4 commits into from Mar 28, 2023

Conversation

jvm986
Copy link
Contributor

@jvm986 jvm986 commented Mar 28, 2023 •
edited by gmlewis

Fixes: #2722

@jvm986 jvm986 marked this pull request as ready for review March 28, 2023 08:15
@jvm986 jvm986 changed the title Add CanAdminsBypass to Environment Add CanAdminsBypass to Environment Mar 28, 2023
jvm986
jvm986 commented Mar 28, 2023
View reviewed changes
github/repos_environments.go Outdated Show resolved Hide resolved
@jvm986 jvm986 marked this pull request as draft March 28, 2023 10:33
@jvm986 jvm986 marked this pull request as ready for review March 28, 2023 10:36
gmlewis
gmlewis requested changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jvm986 !
Please run go generate ./... in the top of this repo and push the changes to this PR.
See CONTRIBUTING.md for more details.

@jvm986 jvm986 requested a review from gmlewis March 28, 2023 13:13
gmlewis
gmlewis approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jvm986 !
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@795005a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2721   +/-   ##
=========================================
  Coverage          ?   98.05%           
=========================================
  Files             ?      131           
  Lines             ?    11459           
  Branches          ?        0           
=========================================
  Hits              ?    11236           
  Misses            ?      152           
  Partials          ?       71
Impacted Files Coverage Δ
github/repos_environments.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis merged commit a934ccc into google:master Mar 28, 2023
9 checks passed
@jvm986 jvm986 deleted the add_can_admins_bypass_environment_response_value branch March 28, 2023 13:45
@jvm986 jvm986 mentioned this pull request Mar 29, 2023
Closed
@enricojonas enricojonas mentioned this pull request Jul 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support can_admins_bypass on Environment struct
2 participants
@jvm986 @gmlewis