Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BuildType to GitHub Repo Pages #2724

Merged
merged 1 commit into from Mar 30, 2023
Merged

Add BuildType to GitHub Repo Pages #2724

merged 1 commit into from Mar 30, 2023

Conversation

brandonstubbs
Copy link
Contributor

resolves: #2723

@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited

Codecov Report

Merging #2724 (13c9341) into master (6bba7a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 13c9341 differs from pull request most recent head 217f638. Consider uploading reports for the commit 217f638 to get more accurate results

@@           Coverage Diff           @@
##           master    #2724   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         131      131           
  Lines       11463    11464    +1     
=======================================
+ Hits        11237    11238    +1     
  Misses        154      154           
  Partials       72       72
Impacted Files Coverage Δ
github/repos_pages.go 97.14% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @brandonstubbs !
LGTM.

Awaiting LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 29, 2023
Sairaviteja27
Sairaviteja27 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@Sairaviteja27 Sairaviteja27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 30, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 30, 2023

Thank you, @Sairaviteja27 !
Merging.

@gmlewis gmlewis merged commit bd31be8 into google:master Mar 30, 2023
7 checks passed
@gmlewis gmlewis changed the title Add BuildType to Github Repo Pages Add BuildType to GitHub Repo Pages Mar 30, 2023
@0x46616c6b 0x46616c6b mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@Sairaviteja27 Sairaviteja27 Sairaviteja27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Pages source
3 participants
@brandonstubbs @gmlewis @Sairaviteja27