Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CanAdminsBypass to CreateUpdateEnvironment #2727

Merged
merged 3 commits into from Mar 30, 2023
Merged

Add CanAdminsBypass to CreateUpdateEnvironment #2727

merged 3 commits into from Mar 30, 2023

Conversation

jvm986
Copy link
Contributor

@jvm986 jvm986 commented Mar 29, 2023 •
edited

Addresses #2725

@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited

Codecov Report

Merging #2727 (1973bc4) into master (6bba7a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2727   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         131      131           
  Lines       11463    11466    +3     
=======================================
+ Hits        11237    11240    +3     
  Misses        154      154           
  Partials       72       72
Impacted Files Coverage Δ
github/repos_environments.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jvm986 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 29, 2023
@cbrgm
Copy link
Contributor

cbrgm commented Mar 30, 2023 •
edited

Good job @jvm986 and thanks for your fast response @gmlewis !

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 30, 2023

@cbrgm - can you please give an LGTM+Approval?

cbrgm
cbrgm approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@cbrgm cbrgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 30, 2023

Thank you, @cbrgm !
Merging.

@gmlewis gmlewis merged commit 78c5d00 into google:master Mar 30, 2023
8 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@cbrgm cbrgm cbrgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jvm986 @cbrgm @gmlewis