Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deleting an org #2728

Merged
merged 1 commit into from Mar 31, 2023
Merged

Add support for deleting an org #2728

merged 1 commit into from Mar 31, 2023
+38 −0

Conversation

tjcorr
Copy link
Contributor

@tjcorr tjcorr commented Mar 30, 2023 •
edited by gmlewis

Fixes: #2726.

@gmlewis gmlewis changed the title Add support for deleting an org, fixes #2726 Add support for deleting an org Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2728 (35abceb) into master (bd31be8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         131      131           
  Lines       11481    11488    +7     
=======================================
+ Hits        11255    11262    +7     
  Misses        154      154           
  Partials       72       72
Impacted Files Coverage Δ
github/orgs.go 97.11% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use only a single client for all APIs in this repo and therefore we don't have the stutter problem, could we please clarify the method name by calling it DeleteOrg?

@tjcorr
Copy link
Contributor Author

tjcorr commented Mar 30, 2023 •
edited

Since we use only a single client for all APIs in this repo and therefore we don't have the stutter problem, could we please clarify the method name by calling it DeleteOrg?

I was just matching the format I saw in other areas like: https://github.com/google/go-github/blob/master/github/repos.go#L590-L601

You would still invoke the API by referencing organizations: client.Organizations.Delete

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 30, 2023

Ah! You are right. My bad. Never mind. Please ignore me. 😂

gmlewis
gmlewis approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tjcorr !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 30, 2023
valbeat
valbeat approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 31, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 31, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 388d921 into google:master Mar 31, 2023
9 checks passed
@tjcorr tjcorr mentioned this pull request Apr 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for deleting an organization.
3 participants
@tjcorr @gmlewis @valbeat