Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the actions required workflows APIs #2730

Merged
merged 8 commits into from Apr 4, 2023
Merged

Implement the actions required workflows APIs #2730

merged 8 commits into from Apr 4, 2023

Conversation

avivek
Copy link
Contributor

@avivek avivek commented Mar 30, 2023 •
edited

Have implemented the API's that would enable managing Required Workflows.

Merging this Fixes #2729

@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited

Codecov Report

Merging #2730 (4a1ad13) into master (b1c53f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   98.03%   98.05%   +0.01%     
==========================================
  Files         131      132       +1     
  Lines       11505    11611     +106     
==========================================
+ Hits        11279    11385     +106     
  Misses        154      154              
  Partials       72       72
Impacted Files Coverage Δ
github/actions_required_workflows.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
It looks like the linter also caught a bunch of things (let me know if you can't see them), so I'm going to cut my review short and let you address them. Please let me know when you are ready for a full review.

github/actions_required_workflows.go Outdated Show resolved Hide resolved
github/actions_required_workflows_test.go Show resolved Hide resolved
github/actions_required_workflows.go Outdated Show resolved Hide resolved
github/actions_required_workflows.go Outdated Show resolved Hide resolved
github/actions_required_workflows.go Show resolved Hide resolved
github/actions_required_workflows.go Outdated Show resolved Hide resolved
@avivek avivek requested a review from gmlewis April 1, 2023 05:23
@avivek
Copy link
Contributor Author

avivek commented Apr 1, 2023

Hi @gmlewis ,
I have made the changes and requested re-review.
Pls let me know if there is any further changes required.
Thanks.

gmlewis
gmlewis requested changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
Just a few more tweaks, please.

github/actions_required_workflows.go Outdated Show resolved Hide resolved
github/actions_required_workflows.go Outdated Show resolved Hide resolved
github/actions_required_workflows.go Outdated Show resolved Hide resolved
github/actions_required_workflows.go Outdated Show resolved Hide resolved
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 1, 2023

It looks like you might also have to run gofmt on the files you modified and run go generate ./... and push the results (not force-push) to the repo to get the linter to pass its tests. Thanks.
See CONTRIBUTING.md for more details.

@avivek
Copy link
Contributor Author

avivek commented Apr 2, 2023

Hi @gmlewis ,
Thanks for the quick review, the changes have now been committed.
I have requested for you re-review.

@avivek avivek requested a review from gmlewis April 2, 2023 04:33
@avivek
Copy link
Contributor Author

avivek commented Apr 3, 2023

Hi @gmlewis ,
Addressed your comment. Hope all set now.
Thanks.

@avivek avivek requested a review from gmlewis April 3, 2023 08:10
@gmlewis gmlewis changed the title Implemented the required workflow API's Implement the actions required workflows APIs Apr 3, 2023
gmlewis
gmlewis approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avivek !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 3, 2023
valbeat
valbeat approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 4, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 4, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 8b1caac into google:master Apr 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required Workflow Support
3 participants
@avivek @gmlewis @valbeat