Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to Branch Protection endpoint #2744

Merged
merged 3 commits into from Apr 9, 2023
Merged

Add fields to Branch Protection endpoint #2744

merged 3 commits into from Apr 9, 2023

Conversation

yardenshoham
Copy link
Contributor

Fixes #2719

This adds a few fields that were requested in #2719.

Fixes #2719

This adds a few fields that were requested in #2719.
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #2744 (23e1c6e) into master (4fec23d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2744   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11611    11611           
=======================================
  Hits        11385    11385           
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/repos.go 98.84% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yardenshoham.
Please correct the issues below and make sure to re-run gofmt and go generate ./... and push (not force-push since we always squash and merge PRs in this repo) the changes to this PR.

github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
@yardenshoham
Copy link
Contributor Author

Thanks, changes applied

github/repos.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yardenshoham !
LGTM.
Merging.

@gmlewis gmlewis merged commit 4caa1d6 into google:master Apr 9, 2023
9 checks passed
@yardenshoham yardenshoham deleted the issues/2719 branch April 9, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fields to get branch protection API to match GitHub APIs
2 participants