Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS health checks support for GitHub Pages #2746

Merged
merged 3 commits into from Apr 12, 2023
Merged

Add DNS health checks support for GitHub Pages #2746

merged 3 commits into from Apr 12, 2023

Conversation

denist11
Copy link
Contributor

@denist11 denist11 commented Apr 9, 2023

Fixes #2745

Allows requesting a DNS health check for the CNAME configured for a repository's GitHub Pages.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @oslowalk !
Just a few minor tweaks, please.

github/repos_pages.go Outdated Show resolved Hide resolved
github/repos_pages.go Outdated Show resolved Hide resolved
github/repos_pages.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #2746 (bc30782) into master (4fec23d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2746   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11611    11623   +12     
=======================================
+ Hits        11385    11397   +12     
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/repos_pages.go 97.43% <100.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @oslowalk !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis changed the title Add DNS health checks support for Github Pages Add DNS health checks support for GitHub Pages Apr 12, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 12, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 12, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 683c2d7 into google:master Apr 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for DNS health checks on Pages.
3 participants