Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add omitempty to CreateOrgInvitationOptions fields #2778

Merged
merged 1 commit into from May 2, 2023
Merged

Add omitempty to CreateOrgInvitationOptions fields #2778

merged 1 commit into from May 2, 2023

Conversation

jvm986
Copy link
Contributor

@jvm986 jvm986 commented May 2, 2023 •
edited by gmlewis

Fixes: #2777

cbrgm
cbrgm approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@cbrgm cbrgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2778 (75f68e0) into master (a938017) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2778   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11638    11638           
=======================================
  Hits        11412    11412           
  Misses        154      154           
  Partials       72       72
Impacted Files Coverage Δ
github/orgs_members.go 98.35% <ø> (ø)

@gmlewis gmlewis changed the title add omitempty to CreateOrgInvitationOptions fields Add omitempty to CreateOrgInvitationOptions fields May 2, 2023
gmlewis
gmlewis approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jvm986 and @cbrgm !
LGTM.
Merging.

@gmlewis gmlewis merged commit 1b6f3a3 into google:master May 2, 2023
9 checks passed
@gmlewis gmlewis mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@cbrgm cbrgm cbrgm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add omitempty to CreateOrgInvitationOptions
3 participants
@jvm986 @gmlewis @cbrgm