Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "new_name" parameter to repo transfer request (#2787) #2788

Merged
merged 4 commits into from May 26, 2023

Conversation

kgalli
Copy link
Contributor

@kgalli kgalli commented May 26, 2023

Resolves: #2787

@google-cla
Copy link

google-cla bot commented May 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kgalli kgalli changed the title Add "new_name" prameter to repo transfer request (#2787) Add "new_name" parameter to repo transfer request (#2787) May 26, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kgalli !
After you make the requested change, please run "go generate ./..." and push (not force-push) the results to this PR, as described in CONTRIBUTING.md.

github/repos.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #2788 (fce6b4a) into master (f96b64e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2788   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         132      132           
  Lines       11650    11650           
=======================================
  Hits        11424    11424           
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/orgs_audit_log.go 100.00% <ø> (ø)
github/repos.go 98.84% <ø> (ø)

@kgalli
Copy link
Contributor Author

kgalli commented May 26, 2023

@gmlewis thanks for the hint. I updated the code and run the generate command. Have to admit I haven't thought about the accessors. Very nice that you have generators in place for that.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kgalli !
LGTM.
Merging after tests pass.

@gmlewis gmlewis merged commit 9e4ce88 into google:master May 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing parameter "new_name" to repository transfer request
2 participants