Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DependabotSecretsSelectedRepoIDs type to []int64 #2794

Merged
merged 2 commits into from Jun 5, 2023

Conversation

jburandt
Copy link
Contributor

@jburandt jburandt commented Jun 1, 2023

According to the docs, the API for setting a repos access to dependabot secrets is expecting an array of integers.

https://docs.github.com/en/rest/dependabot/secrets?apiVersion=2022-11-28#set-selected-repositories-for-an-organization-secret

@google-cla
Copy link

google-cla bot commented Jun 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jun 1, 2023
@gmlewis gmlewis changed the title update repo id type to match doc requirements Update repo ID type to match doc requirements Jun 1, 2023
@gmlewis gmlewis changed the title Update repo ID type to match doc requirements Update DependabotSecretsSelectedRepoIDs type to []int64 Jun 1, 2023
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 1, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jburandt !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #2794 (c800c9f) into master (d6880db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2794   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         132      132           
  Lines       11650    11650           
=======================================
  Hits        11424    11424           
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/dependabot_secrets.go 100.00% <ø> (ø)

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 5, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 5, 2023
@gmlewis gmlewis merged commit bc019ca into google:master Jun 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants