New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support code scanning default setup configuration #2808
Support code scanning default setup configuration #2808
Conversation
Signed-off-by: YuyaAbo <b1011211@gmail.com>
Signed-off-by: YuyaAbo <b1011211@gmail.com>
go generate github.com/google/go-github/... Signed-off-by: YuyaAbo <b1011211@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2808 +/- ##
=======================================
Coverage 98.10% 98.11%
=======================================
Files 134 134
Lines 11950 11976 +26
=======================================
+ Hits 11724 11750 +26
Misses 154 154
Partials 72 72
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @YuyaAbo !
This looks great... just a couple minor tweaks, please, then we will just need a second LGTM+Approval from any other contributor to this repo before merging.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @YuyaAbo !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @valbeat ! |
fix #2751
I created a PR because the Issue stated the following: Thanks for creating the Issue.