Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support code scanning default setup configuration #2808

Conversation

YuyaAbo
Copy link
Contributor

@YuyaAbo YuyaAbo commented Jun 18, 2023

fix #2751

I created a PR because the Issue stated the following: Thanks for creating the Issue.

I'll pick this up if I get a chance, but if someone beats me to it, feel free.

Signed-off-by: YuyaAbo <b1011211@gmail.com>
Signed-off-by: YuyaAbo <b1011211@gmail.com>
go generate github.com/google/go-github/...

Signed-off-by: YuyaAbo <b1011211@gmail.com>
@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #2808 (eec349e) into master (6a57598) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2808   +/-   ##
=======================================
  Coverage   98.10%   98.11%           
=======================================
  Files         134      134           
  Lines       11950    11976   +26     
=======================================
+ Hits        11724    11750   +26     
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <100.00%> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @YuyaAbo !
This looks great... just a couple minor tweaks, please, then we will just need a second LGTM+Approval from any other contributor to this repo before merging.

github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 18, 2023
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@YuyaAbo YuyaAbo requested a review from gmlewis June 18, 2023 19:09
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @YuyaAbo !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 19, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit b2ae94a into google:master Jun 19, 2023
9 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 19, 2023
@YuyaAbo YuyaAbo deleted the support-code-scanning-default-setup-configuration branch June 19, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Code Scanning default setup API
3 participants