Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement installation_target webhook event type #2829

Merged
merged 2 commits into from Jul 19, 2023

Conversation

RickleAndMortimer
Copy link
Contributor

@RickleAndMortimer RickleAndMortimer commented Jul 10, 2023

Implements the installation_target webhook event type.

Description from the API:

This event occurs when there is activity relating to the user or organization account that a GitHub App is installed on

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2829 (b7da72e) into master (9f7124c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2829   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         136      136           
  Lines       12279    12281    +2     
=======================================
+ Hits        12041    12043    +2     
  Misses        162      162           
  Partials       76       76           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

@RickleAndMortimer RickleAndMortimer changed the title Implemented installation_target webhook Implemented installation_target webhook event type Jul 10, 2023
@gmlewis gmlewis changed the title Implemented installation_target webhook event type Implement installation_target webhook event type Jul 10, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @RickleAndMortimer !
Just a few tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 10, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @RickleAndMortimer !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 19, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 19, 2023

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 461d387 into google:master Jul 19, 2023
7 checks passed
@RickleAndMortimer RickleAndMortimer deleted the installation_target_event branch July 20, 2023 23:17
@mnafees
Copy link
Contributor

mnafees commented Jul 27, 2023

When can we expect a release to be published with this change?

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 27, 2023

@mnafees - it would be nice to get a couple outstanding PRs merged in before the release since we already have breaking changes. Would you be interested in reviewing these two PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants