Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret type display to secret scanning alert #2834

Merged
merged 1 commit into from Jul 20, 2023
Merged

Add secret type display to secret scanning alert #2834

merged 1 commit into from Jul 20, 2023

Conversation

salamachinas
Copy link
Contributor

added support for getting secret type display name when listing secret scanning alerts

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2834 (e675dec) into master (461d387) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         137      137           
  Lines       12291    12291           
=======================================
  Hits        12053    12053           
  Misses        162      162           
  Partials       76       76           
Impacted Files Coverage Δ
github/secret_scanning.go 100.00% <ø> (ø)

@gmlewis gmlewis changed the title added secret type display to secret scanning alert Add secret type display to secret scanning alert Jul 20, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @salamachinas !
LGTM.
Merging.

@gmlewis gmlewis merged commit b02bb75 into google:master Jul 20, 2023
9 checks passed
@salamachinas salamachinas deleted the secret-type-display-name branch July 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants