Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OldLogin field to AuditEntryData #2850

Merged
merged 3 commits into from Jul 28, 2023
Merged

Add OldLogin field to AuditEntryData #2850

merged 3 commits into from Jul 28, 2023

Conversation

lmartinking
Copy link
Contributor

@lmartinking lmartinking commented Jul 28, 2023

When renaming a Github organisation, the audit log entry (with action org.rename) will contain data.old_login which provides the prior name of the organisation.

This PR builds upon prior work which added support for the data field within an Audit Log entry.

@lmartinking lmartinking marked this pull request as ready for review July 28, 2023 15:06
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2850 (61560e8) into master (44d09ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2850   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         138      138           
  Lines       12318    12318           
=======================================
  Hits        12080    12080           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/orgs_audit_log.go 100.00% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lmartinking !
LGTM.
Merging.

@gmlewis gmlewis merged commit f897b2c into google:master Jul 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants