Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Security Advisories Request CVE endpoint #2857

Merged
merged 5 commits into from Aug 13, 2023
Merged

Add support for Security Advisories Request CVE endpoint #2857

merged 5 commits into from Aug 13, 2023

Conversation

be0x74a
Copy link
Contributor

@be0x74a be0x74a commented Aug 5, 2023

Fixes #2855

gmlewis
gmlewis requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a

README.md Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
github/security_advisories.go Outdated Show resolved Hide resolved
github/security_advisories.go Outdated Show resolved Hide resolved
github/security_advisories_test.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited

Codecov Report

Merging #2857 (2353a17) into master (b989bf4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2857   +/-   ##
=======================================
  Coverage   98.06%   98.07%           
=======================================
  Files         138      139    +1     
  Lines       12327    12342   +15     
=======================================
+ Hits        12089    12104   +15     
  Misses        162      162           
  Partials       76       76
Files Changed Coverage Δ
github/github.go 97.97% <100.00%> (+<0.01%) ⬆️
github/security_advisories.go 100.00% <100.00%> (ø)

@be0x74a be0x74a requested a review from gmlewis August 8, 2023 08:15
@be0x74a be0x74a requested a review from gmlewis August 8, 2023 12:05
gmlewis
gmlewis approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @be0x74a !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 8, 2023
@be0x74a
Copy link
Contributor Author

be0x74a commented Aug 8, 2023

Thank you for the time you took to review and feedback on the PR @gmlewis

vandanrohatgi
vandanrohatgi approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@vandanrohatgi vandanrohatgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 13, 2023

Thank you, @vandanrohatgi !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 13, 2023
@gmlewis gmlewis merged commit f36dfa5 into google:master Aug 13, 2023
9 checks passed
@gmlewis gmlewis mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@vandanrohatgi vandanrohatgi vandanrohatgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new API to Request a CVE for a repository security advisory
3 participants
@be0x74a @gmlewis @vandanrohatgi