Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropped test error #2858

Merged
merged 1 commit into from Aug 7, 2023
Merged

Fix dropped test error #2858

merged 1 commit into from Aug 7, 2023

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Aug 7, 2023

This picks up a dropped err variable in tests and clarifies the error message.

@gmlewis gmlewis changed the title github: fix dropped test error Fix dropped test error Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2858 (b5fd0f5) into master (a8da03b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2858   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         138      138           
  Lines       12327    12327           
=======================================
  Hits        12089    12089           
  Misses        162      162           
  Partials       76       76           

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alrs !
LGTM.
Merging.

@gmlewis gmlewis merged commit d24bbc2 into google:master Aug 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants