Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching SBOMs #2869

Merged
merged 17 commits into from Aug 16, 2023
Merged

Add support for fetching SBOMs #2869

merged 17 commits into from Aug 16, 2023

Conversation

vandanrohatgi
Copy link
Contributor

@vandanrohatgi vandanrohatgi commented Aug 14, 2023

Closes #2864

Adds support for fetching Software Bill of materials (SBOM) for a repository.

  • go generate
  • go test
  • go vet

github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
vandanrohatgi and others added 12 commits August 14, 2023 19:09
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2869 (c48702b) into master (3ecf12c) will decrease coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.02%     
==========================================
  Files         139      140       +1     
  Lines       12348    12269      -79     
==========================================
- Hits        12110    12031      -79     
  Misses        162      162              
  Partials       76       76              
Files Changed Coverage Δ
github/dependency_graph.go 100.00% <100.00%> (ø)
github/github.go 97.97% <100.00%> (+<0.01%) ⬆️

... and 6 files with indirect coverage changes

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi !
Just a couple minor comment nits, please, that I apparently missed the first time
before we await a second LGTM+Approval from any other contributor to this repo before merging.

github/dependency_graph.go Outdated Show resolved Hide resolved
github/dependency_graph.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 15, 2023
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@vandanrohatgi
Copy link
Contributor Author

Thank you so much for the valuable feedback @gmlewis ! Learned a lot. Though I feel I only increased your workload rather than contributing :)

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 15, 2023

Thank you so much for the valuable feedback @gmlewis ! Learned a lot. Though I feel I only increased your workload rather than contributing :)

No, not at all, @vandanrohatgi ! Your contributions are appreciated more than you know!
I couldn't maintain this repo without the help of wonderful contributors like yourself.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis changed the title Add support for fetching sboms Add support for fetching SBOMs Aug 15, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 16, 2023

@Parker77 - do you have time for a code review, please?

Co-authored-by: Parker77 <20973702+Parker77@users.noreply.github.com>
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 16, 2023

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 0c562f6 into google:master Aug 16, 2023
8 of 9 checks passed
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Repository SBOM generation
3 participants