New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enable/disable private vulnerability reporting on repositories #2887
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2887 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 140 140
Lines 12269 12293 +24
=======================================
+ Hits 12031 12055 +24
Misses 162 162
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vandanrohatgi !
A few minor tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
In this repo, we do not typically add to the integration tests anymore. Having said that, we place a high value on unit tests in this repo and want every endpoint to be exercised "round-trip" with an in-memory http server to verify that every one looks like it should work in real practice. So you are proceeding along just as planned, and we really appreciate your contributions, @vandanrohatgi ! Keep up the great work! 😁 ❤️ |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Thank you for making this project such a pleasure to work with! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vandanrohatgi !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
LGTM 👍🏽 |
Thank you, @mnafees ! |
Closes #2883
Please let me know if the method names are not descriptive enough or just need to be changed.
Also, something that's been bugging me. In my previous PR, I did some actual testing aside from the unit tests. While not present in CONTRIBUTING.md , is it advisable/necessary/optional to perform actual testing (importing the library, calling the new method and examine response).