Add GenerateEnterpriseJITConfig #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With version 3.10 of GitHub Enterprise server, the new just-in-time runner configuration is available for enterprises. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Codecov Report
@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
- Coverage 98.12% 98.06% -0.06%
==========================================
Files 142 140 -2
Lines 12453 12306 -147
==========================================
- Hits 12219 12068 -151
- Misses 159 162 +3
- Partials 75 76 +1
|
gmlewis
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Thank you, @gabriel-samfira !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
@WillAbides - do you have time for a code review on this one? |
|
No worries at all @gmlewis ! |
WillAbides
approved these changes
Sep 6, 2023
|
Thank you, @WillAbides ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 3.10 of GitHub Enterprise server, the new just-in-time runner configuration is available for enterprises.
See: https://docs.github.com/en/enterprise-cloud@latest/rest/actions/self-hosted-runners?apiVersion=2022-11-28#create-configuration-for-a-just-in-time-runner-for-an-enterprise
CC: @mkulke