New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enterprise runner group operations #2891
Add enterprise runner group operations #2891
Conversation
This change adds runner group operations on enterprises. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @gabriel-samfira for the very clean and well-written PR!
❤️
Just one tiny nit, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @gabriel-samfira !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
I had forgotten about the |
For consistency with ActionsService, should the "*RunnerGroup" methods be renamed to "*EnterpriseRunnerGroup"? This PR also takes the opposite approach with the "*GroupRunners" methods. ActionsService doesn't include "Organization" in those method names, but EnterpriseService includes "Enterprise". I think the ActionsService names make more sense because they are acting on a "Runner", not an "OrganizationRunner" or "EnterpriseRunner". |
Excellent points, @WillAbides - I think you are right. |
Ohh wow. For some reason I did not get a notification for your comments. I will make these changes ASAP. Thanks for the review! |
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Hopefully I got all the names right. Let me know if I missed (or misunderstood) anything. |
Thank you, @WillAbides ! |
Appreciate the work here! My team will benefit from these changes as well. Thanks, everyone. |
This change adds runner group operations on enterprises. The operations are essentially a mirror of the org runner group code, adapted for enterprises.