Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ListServiceHooks #2917

Merged
merged 1 commit into from Sep 18, 2023
Merged

Conversation

WillAbides
Copy link
Contributor

closes #2916

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2917 (e94283e) into master (b700431) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2917      +/-   ##
==========================================
- Coverage   98.12%   98.11%   -0.01%     
==========================================
  Files         142      142              
  Lines       12453    12439      -14     
==========================================
- Hits        12219    12205      -14     
  Misses        159      159              
  Partials       75       75              
Files Changed Coverage Δ
github/misc.go 100.00% <ø> (ø)

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Sep 5, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @WillAbides !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 18, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 18, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 0e8dfae into google:master Sep 18, 2023
9 checks passed
@WillAbides WillAbides deleted the kill-service-hooks branch September 18, 2023 13:42
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListServiceHooks appears to no longer be supported
3 participants