Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct NewEnterpriseClient deprecation message #2923

Merged
merged 1 commit into from Sep 18, 2023

Conversation

oschwald
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Sep 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@WillAbides WillAbides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my mistake. Thank you for finding and fixing it.

@oschwald
Copy link
Contributor Author

I signed the CLA.

@WillAbides
Copy link
Contributor

I signed the CLA.

Thanks. Just to set your expectations, the primary maintainer is out this week, so there is a good chance this won't get a second review or be merged for a week or so.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2923 (544b427) into master (fd33b81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2923   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         143      143           
  Lines       12609    12609           
=======================================
  Hits        12379    12379           
  Misses        156      156           
  Partials       74       74           
Files Changed Coverage Δ
github/github.go 98.11% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @oschwald and @WillAbides !
LGTM.
Merging.

@gmlewis gmlewis merged commit 3c1590d into google:master Sep 18, 2023
10 checks passed
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants