Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing secret scanning alert fields #2930

Merged
merged 2 commits into from Sep 18, 2023
Merged

Add missing secret scanning alert fields #2930

merged 2 commits into from Sep 18, 2023

Conversation

vandanrohatgi
Copy link
Contributor

Closes #2929

  • go generate
  • go vet
  • go test

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2930 (6e2589e) into master (fd33b81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2930   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         143      143           
  Lines       12609    12609           
=======================================
  Hits        12379    12379           
  Misses        156      156           
  Partials       74       74
Files Changed Coverage Δ
github/secret_scanning.go 100.00% <ø> (ø)

WillAbides
WillAbides approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@WillAbides WillAbides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The lint failure is a timeout. I verified locally that lint passes on this branch, but somebody with permissions will need to trigger re-running the action.

gmlewis
gmlewis approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vandanrohatgi and @WillAbides !
LGTM.
Merging.

@gmlewis gmlewis merged commit 477e109 into google:master Sep 18, 2023
10 checks passed
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
@vandanrohatgi @gmlewis
Add missing secret scanning alert fields (google#2930)
c8a58d7 
Fixes: google#2929.
@gmlewis gmlewis mentioned this pull request Oct 11, 2023
Merged
@vandanrohatgi vandanrohatgi deleted the issue2929 branch December 5, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAbides WillAbides WillAbides approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for additional response fields
3 participants
@vandanrohatgi @WillAbides @gmlewis