Remove openpgp and change CreateCommit signature #2935
Merged
+169
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2935 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 143 143
Lines 12597 12602 +5
=======================================
+ Hits 12367 12372 +5
Misses 156 156
Partials 74 74
|
gmlewis
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Awesome, @WillAbides !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Comment on lines
+156
to
+158
| opts.Signer = github.MessageSignerFunc(func(w io.Writer, r io.Reader) error { | ||
| return openpgp.ArmoredDetachSign(w, key, r, nil) | ||
| }) |
There was a problem hiding this comment.
TIL that you can wrap a single func in a type cast that can then be used as a receiver in order to satisfy an interface...
so cool, @WillAbides - thank you!
gmlewis
added
NeedsReview
valbeat
approved these changes
Sep 21, 2023
|
Thank you, @valbeat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2932
In #2932 we discussed removing the dependency on openpgp and replacing Commit.SigningKey with an interface.
While I was working on it, I realized that this should be an option to CreateCommit instead of a Commit field. I was going to just ignore this, but adding an interface field to Commit caused issues with Stringify and the generated string tests. Instead of unwinding all that, I'm doing the easy thing first and adding a CreateCommitOptions struct. I can change approaches if necessary.