Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch protection request fields #2977

Merged

Conversation

viqueen
Copy link
Contributor

@viqueen viqueen commented Oct 31, 2023

Fixes #2976

The property Checks on RequiredStatusChecks type is not required according to GitHub api, so using the omitempty tag

@gmlewis gmlewis changed the title bugfix: branch protection request fields Fix branch protection request fields Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2977 (23d33dd) into master (5b34ea7) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2977   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         149      149           
  Lines       12796    12796           
=======================================
  Hits        12555    12555           
  Misses        166      166           
  Partials       75       75           
Files Coverage Δ
github/repos.go 98.89% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viqueen !
LGTM.
Merging.

@gmlewis gmlewis merged commit f643c0f into google:master Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Branch Protection fields
2 participants