New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Required Workflows #2979
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2979 +/- ##
==========================================
- Coverage 97.94% 97.92% -0.03%
==========================================
Files 149 149
Lines 12836 12854 +18
==========================================
+ Hits 12572 12587 +15
- Misses 188 190 +2
- Partials 76 77 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @claystation !
After a few tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Hey @gmlewis ! Thanks for the review :) I updated the code to reflect the correct suggestions! |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
It looks like some |
Hey @gmlewis! I did a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @claystation !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thank you, @valbeat ! |
Fixes #2978
Suggestion to add support for Required Workflows in Github API.