Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Required Workflows #2979

Merged
merged 8 commits into from Nov 8, 2023

Conversation

claystation
Copy link
Contributor

@claystation claystation commented Oct 31, 2023

Fixes #2978
Suggestion to add support for Required Workflows in Github API.

Copy link

google-cla bot commented Oct 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title Support for Required Workflows Add support for Required Workflows Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2979 (7057678) into master (630bfdb) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
- Coverage   97.94%   97.92%   -0.03%     
==========================================
  Files         149      149              
  Lines       12836    12854      +18     
==========================================
+ Hits        12572    12587      +15     
- Misses        188      190       +2     
- Partials       76       77       +1     
Files Coverage Δ
github/repos_rules.go 98.85% <83.33%> (-1.15%) ⬇️

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @claystation !
After a few tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/repos_rules.go Outdated Show resolved Hide resolved
github/repos_rules.go Outdated Show resolved Hide resolved
github/repos_rules.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 3, 2023
@claystation
Copy link
Contributor Author

Hey @gmlewis ! Thanks for the review :) I updated the code to reflect the correct suggestions!

github/repos_rules.go Outdated Show resolved Hide resolved
claystation and others added 2 commits November 6, 2023 09:33
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 6, 2023

It looks like some gofmt needs to be called, then we should be good to move forward on this PR.

@claystation
Copy link
Contributor Author

Hey @gmlewis! I did a gofmt and generated files as requested in the check :) Should be good to go now!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @claystation !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 8, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 14dccc2 into google:master Nov 8, 2023
5 of 7 checks passed
@claystation claystation deleted the required-workflows-rulesets branch November 9, 2023 10:00
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Required Workflows in rulesets
3 participants