Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot alert update endpoint #2981

Merged
merged 4 commits into from Nov 3, 2023

Conversation

mcollao-hc
Copy link
Contributor

Adds support for https://docs.github.com/en/rest/dependabot/alerts?apiVersion=2022-11-28#update-a-dependabot-alert.

Closes #2922. This is also a dupe of #2955, which hasn't seen action in a few weeks and had build errors.

Copy link

google-cla bot commented Oct 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title add dependabot alert update endpoint Add dependabot alert update endpoint Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2981 (82aef03) into master (f643c0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2981   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         149      149           
  Lines       12796    12808   +12     
=======================================
+ Hits        12555    12567   +12     
  Misses        166      166           
  Partials       75       75           
Files Coverage Δ
github/dependabot_alerts.go 100.00% <100.00%> (ø)

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2023

Thank you, @mcollao-hc - I apologize for the delay in taking a look at this.

Please perform step 4 in CONTRIBUTING.md and push the results to this PR.

@mcollao-hc
Copy link
Contributor Author

No worries, thanks for the review. Pushed the files created from running the script.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2023

Did you run both ./script/generate.sh and ./script/lint.sh ?

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2023

I ask because we have a new metadata field required in the docs for each endpoint (that I believe should be updated for you) that is missing.

@mcollao-hc
Copy link
Contributor Author

Ok think I got it. Had to rebase to pick up the new requirements and added the metadata field to the UpdateAlert function since it wasn't being added automatically.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mcollao-hc !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 3, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 3, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2023

Thank you, @WillAbides !
Merging.

@gmlewis gmlewis merged commit a5b1cea into google:master Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing function to update dependabot alerts
3 participants