Deprecate RepositoriesService.List #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2988 +/- ##
==========================================
- Coverage 98.11% 97.94% -0.18%
==========================================
Files 149 149
Lines 12808 12836 +28
==========================================
+ Hits 12567 12572 +5
- Misses 166 188 +22
- Partials 75 76 +1
|
|
To address @gmlewis's comment from the issue, I think the context of having a user parameter is enough to make it clear what Also, in the issue I proposed ListForUser and ListForAuthenticatedUser, but I changed it to ListByUser and ListByAuthenticatedUser because I found precedents "RepositoryService.ListByOrg" and "IssuesService.ListByRepo". |
gmlewis
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
Thank you, @WillAbides !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
valbeat
approved these changes
Nov 7, 2023
|
Thank you, @valbeat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2987
This deprecates
RepositoriesService.Listand replaces it with two new methods:RepositoriesService.ListByUserandRepositoriesService.ListByAuthenticatedUser. See #2987 for the justification.