Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code_search and dependency_snapshots for RateLimits #3019

Merged
merged 5 commits into from Dec 15, 2023
Merged

Add code_search and dependency_snapshots for RateLimits #3019

merged 5 commits into from Dec 15, 2023

Conversation

rufusnufus
Copy link
Contributor

resolves #3018

Copy link

google-cla bot commented Dec 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rufusnufus rufusnufus marked this pull request as draft December 5, 2023 23:13
@rufusnufus rufusnufus marked this pull request as ready for review December 5, 2023 23:26
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb8a83d) 97.91% compared to head (bc30e10) 97.92%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   97.91%   97.92%           
=======================================
  Files         150      150           
  Lines       12980    12990   +10     
=======================================
+ Hits        12710    12720   +10     
  Misses        192      192           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rufusnufus !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 6, 2023
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 15, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 15, 2023

Thank you, @valbeat !
Merging after tests pass.

@gmlewis gmlewis merged commit 2cc47f9 into google:master Dec 15, 2023
7 checks passed
gmlewis pushed a commit to WillAbides/go-github that referenced this pull request Dec 18, 2023
gmlewis pushed a commit to o-sama/go-github that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for code_search and dependency_snapshots for RateLimits
3 participants