Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copilot API payload #3034

Merged
merged 3 commits into from Dec 19, 2023
Merged

Fix copilot API payload #3034

merged 3 commits into from Dec 19, 2023

Conversation

zetaab
Copy link
Contributor

@zetaab zetaab commented Dec 19, 2023

small fix to #2973

cc @gmlewis @o-sama

@gmlewis gmlewis changed the title fix copilot api payload Fix copilot API payload Dec 19, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 19, 2023

Investigating why tests are failing...

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 19, 2023

Oh, I see... the unit tests need updating.
@zetaab - please make sure unit tests pass on your side... then push the changes (not force-push) to this PR to fix them.
Please see CONTRIBUTING.md step 4 for details. Thanks.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zetaab !

Let's please keep the struct field names matching the JSON field tag names.

I'm not going to mark this as a Breaking API change since this was just introduced within this major version.

github/copilot.go Outdated Show resolved Hide resolved
github/copilot.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zetaab !
LGTM.
Merging after tests pass.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d6658a) 97.71% compared to head (af72ec5) 97.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3034   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         152      152           
  Lines       13241    13241           
=======================================
  Hits        12939    12939           
  Misses        213      213           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis merged commit a6f50f1 into google:master Dec 19, 2023
7 checks passed
@zetaab zetaab deleted the fixcopilotreqcontent branch December 19, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants