Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deployment protection rules #3050

Merged
merged 5 commits into from Feb 1, 2024

Conversation

abhishekbiyala
Copy link
Contributor

Fixes #3022

Copy link

google-cla bot commented Jan 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title feat: add support for deployment protection rules Add support for deployment protection rules Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9231a0f) 97.71% compared to head (5dcb72a) 97.70%.
Report is 2 commits behind head on master.

Files Patch % Lines
github/code-scanning.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3050      +/-   ##
==========================================
- Coverage   97.71%   97.70%   -0.02%     
==========================================
  Files         152      153       +1     
  Lines       13241    13310      +69     
==========================================
+ Hits        12939    13005      +66     
- Misses        213      215       +2     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @abhishekbiyala !
Just a few minor tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/repos_deployment_protection_rules.go Outdated Show resolved Hide resolved
github/repos_deployment_protection_rules.go Show resolved Hide resolved
github/repos_deployment_protection_rules.go Outdated Show resolved Hide resolved
github/repos_deployment_protection_rules.go Outdated Show resolved Hide resolved
github/repos_deployment_protection_rules.go Outdated Show resolved Hide resolved
github/repos_deployment_protection_rules.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 14, 2024
abhishekbiyala and others added 2 commits January 14, 2024 15:39
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @abhishekbiyala !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@fchimpan
Copy link
Contributor

fchimpan commented Feb 1, 2024

Hi, @abhishekbiyala
Thanks your implementation. LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 1, 2024

Thank you, @fchimpan !
Merging.

@gmlewis gmlewis merged commit 8f2dcee into google:master Feb 1, 2024
5 of 7 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for deployment protection rules for an environment
3 participants