Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaked client transport on copy #3051

Merged
merged 1 commit into from Jan 28, 2024

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jan 16, 2024

Fixes: #3043.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9231a0f) 97.71% compared to head (9424530) 97.69%.
Report is 2 commits behind head on master.

Files Patch % Lines
github/code-scanning.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
- Coverage   97.71%   97.69%   -0.03%     
==========================================
  Files         152      152              
  Lines       13241    13253      +12     
==========================================
+ Hits        12939    12948       +9     
- Misses        213      215       +2     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 16, 2024
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 18, 2024

Awaiting LGTM+Approval from any other contributor to this repo before merging.

@fchimpan
Copy link
Contributor

Hi, @gmlewis !
Thank you for your implementation.
I have tested it in my local environment and can confirm that it is working correctly.
LGTM 🚀

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 28, 2024
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 28, 2024

Thank you, @fchimpan !
Merging.

@gmlewis gmlewis merged commit 536966d into google:master Jan 28, 2024
5 of 7 checks passed
@gmlewis gmlewis deleted the i3043-leaky-client-transport-copy branch January 28, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access token leakage when reusing the client between users
2 participants