Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom properties on Repository and PushEventRepository #3065

Merged
merged 1 commit into from Jan 31, 2024

Conversation

chapurlatn
Copy link
Contributor

Repository and PushEventRepository updated:

CustomProperties map[string]string `json:"custom_properties,omitempty"`

Getters generated.

Scripts fmt, test, link passed.

@chapurlatn
Copy link
Contributor Author

chapurlatn commented Jan 31, 2024

I added it in the "main" set of properties cause it always present and the concept of custom properties is closed to Topics but please note that I can add a space between Topics and CustomProperties to avoid reformating the previous properties.

@chapurlatn
Copy link
Contributor Author

Related issue: #3064

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e574cdf) 97.71% compared to head (de69728) 97.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3065   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         152      152           
  Lines       13335    13335           
=======================================
  Hits        13030    13030           
  Misses        215      215           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chapurlatn !
LGTM.
Merging.

@gmlewis gmlewis merged commit fe77322 into google:master Jan 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants