feat!: Add ListRunnersOptions to support all query parameters #3094
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gmlewis
added
NeedsReview
There was a problem hiding this comment.
Thank you, @fentas !
One tweak, please, then you will need to update your tests and run step 4 scripts listed in CONTRIBUTING.md.
Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
I'll also change the PR title to note that this is a breaking API change.
gmlewis
changed the title
fentas
force-pushed
the
ListRunnersOptions
branch
from
8c8f016
to
765fbf8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.86%
==========================================
Files 153 170 +17
Lines 13390 11403 -1987
==========================================
- Hits 13085 10590 -2495
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
|
Just for future reference, you never need to force push to PRs in this repo (and we prefer if you don't to make reviews easier to see what changed) because we always squash and merge here. Thanks. |
|
Thank you, @be0x74a ! |
Fixes: #3093.
BREAKING-CHANGE: This changes
ListOptionstoListRunnersOptionsinListRunnersandListOrganizationRunners.Let me know if something is missing 🙌
Edit: I agreed to the CLA.